Skip to content

Conversation

@ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented Aug 6, 2025

Fix Reported Gnuton Comparison Errors

Reported here: https://www.snbforums.com/threads/merlinau-v1-5-1-the-ultimate-firmware-auto-updater-webui-gnuton-support.91326/post-964857

The reason appears to be that his setting file still contained the short version, causing the regex in the new modified FWVersionStrToNum function for buildDigits to grabb the last numeric segment of a plain dotted version (the “.2” in 3004.388.9.2) and treating it like a suffix build number.

That makes:
3004.388.9.2 --> buildDigits 02 (wrong - there’s no suffix)
3004.388.9.2-gnuton2 --> buildDigits 02

Recreated below:

image image

Fix Reported Gnuton Comparison Errors
@ExtremeFiretop ExtremeFiretop marked this pull request as ready for review August 6, 2025 03:15
@Martinski4GitHub
Copy link
Collaborator

Martinski4GitHub commented Aug 6, 2025

@ExtremeFiretop,
That was a great catch by the SNB Forum user (scootertramp)!!!
I've reviewed the changes, and they look solid. I think you nailed the solution.

Later tonight (when everyone goes to sleep), I'll run some tests on my PRO router since I have not yet updated to the latest 3006.102.5 F/W release. I'll let you know of the results.

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge!!!

@Martinski4GitHub Martinski4GitHub merged commit 8008a00 into dev Aug 6, 2025
4 checks passed
@Martinski4GitHub
Copy link
Collaborator

@ExtremeFiretop,

I just ran a few tests on my RT-AX86U_PRO to detect the latest RMerlin 3006.102.5 F/W version, and everything went well. The version numbers were generated & compared correctly, and the notification date was updated properly.
Sample screenshots:

Initial detection:

MerliinAU_v1 5 2_FWversionDetectionOK1

Selecting menu option 1:

MerliinAU_v1 5 2_FWversionDetectionOK2

Good to go!!

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Aug 6, 2025

@ExtremeFiretop, That was a great catch by the SNB Forum user (@ScooterTramp)!!! I've reviewed the changes, and they look solid. I think you nailed the solution.

Agreed! Good catch and i won't lie it confused me at first. But once I narrowed down the area of interest it was just a question of what was the best way to deal with it without breaking anything else lol!

Later tonight (when everyone goes to sleep), I'll run some tests on my PRO router since I have not yet updated to the latest 3006.102.5 F/W release. I'll let you know of the results.

Awesome! Yes it's time to pull that PRO router out and put it to work 😉

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Aug 6, 2025

@ExtremeFiretop,

I just ran a few tests on my RT-AX86U_PRO to detect the latest RMerlin 3006.102.5 F/W version, and everything went well. The version numbers were generated & compared correctly, and the notification date was updated properly. Sample screenshots:

Initial detection:

MerliinAU_v1 5 2_FWversionDetectionOK1

Selecting menu option 1:

MerliinAU_v1 5 2_FWversionDetectionOK2

Good to go!!

Perfect... Yes I really wanted to be sure the comparisons were still working correctly.
That function at the end of the day impacts lots based on the comparisons it spits out so it's important we review.

@Martinski4GitHub
Copy link
Collaborator

@ExtremeFiretop,
I just ran a few tests on my RT-AX86U_PRO to detect the latest RMerlin 3006.102.5 F/W version, and everything went well. The version numbers were generated & compared correctly, and the notification date was updated properly. Sample screenshots:

Initial detection:

MerliinAU_v1 5 2_FWversionDetectionOK1

Selecting menu option 1:

MerliinAU_v1 5 2_FWversionDetectionOK2
Good to go!!

Perfect... Yes I really wanted to be sure the comparisons were still working correctly. That function at the end of the day impacts lots based on the comparisons it spits out so it's important we review.

Indeed!! That function cannot be broken!!! It must work every single time for ALL models and F/W releases (Merlin's & Gnuton's).

@ExtremeFiretop ExtremeFiretop deleted the Gnuton-Tweak branch August 7, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants